Lint unused parentheses around method receiver#151986
Draft
chenyukang wants to merge 2 commits into
Draft
Conversation
Collaborator
|
cc @tgross35 |
Collaborator
Collaborator
|
chenyukang
marked this pull request as draft
February 2, 2026 08:36
chenyukang
force-pushed
the
yukang-fix-151985-unused-parens-method-receiver
branch
from
February 2, 2026 08:39
c1b3bf0 to
c6acedc
Compare
chenyukang
commented
Feb 2, 2026
| }, | ||
| alloc, | ||
| )); | ||
| let uninit_ptr: NonNull<_> = (unsafe { &mut *uninit_raw_ptr }).into(); |
Member
Author
There was a problem hiding this comment.
seems better add parens for unsafe block?
This comment has been minimized.
This comment has been minimized.
chenyukang
force-pushed
the
yukang-fix-151985-unused-parens-method-receiver
branch
from
February 2, 2026 08:57
c6acedc to
89085e5
Compare
This comment has been minimized.
This comment has been minimized.
chenyukang
force-pushed
the
yukang-fix-151985-unused-parens-method-receiver
branch
from
February 2, 2026 09:58
926cf7d to
dc54301
Compare
This comment has been minimized.
This comment has been minimized.
chenyukang
force-pushed
the
yukang-fix-151985-unused-parens-method-receiver
branch
from
February 2, 2026 11:06
dc54301 to
5733cfa
Compare
This comment has been minimized.
This comment has been minimized.
chenyukang
force-pushed
the
yukang-fix-151985-unused-parens-method-receiver
branch
from
February 2, 2026 11:36
5733cfa to
39cd80f
Compare
This comment has been minimized.
This comment has been minimized.
chenyukang
force-pushed
the
yukang-fix-151985-unused-parens-method-receiver
branch
from
February 2, 2026 12:10
39cd80f to
823f304
Compare
This comment has been minimized.
This comment has been minimized.
chenyukang
force-pushed
the
yukang-fix-151985-unused-parens-method-receiver
branch
from
February 2, 2026 12:51
823f304 to
4a5a8e7
Compare
This comment has been minimized.
This comment has been minimized.
chenyukang
force-pushed
the
yukang-fix-151985-unused-parens-method-receiver
branch
from
February 2, 2026 13:32
4a5a8e7 to
d657d00
Compare
This comment has been minimized.
This comment has been minimized.
chenyukang
force-pushed
the
yukang-fix-151985-unused-parens-method-receiver
branch
from
February 2, 2026 14:24
d657d00 to
d18d47c
Compare
This comment has been minimized.
This comment has been minimized.
chenyukang
force-pushed
the
yukang-fix-151985-unused-parens-method-receiver
branch
from
February 5, 2026 12:52
d18d47c to
885e44e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
chenyukang
force-pushed
the
yukang-fix-151985-unused-parens-method-receiver
branch
from
March 26, 2026 08:12
885e44e to
e6c8654
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
chenyukang
force-pushed
the
yukang-fix-151985-unused-parens-method-receiver
branch
from
March 26, 2026 12:38
8dff78c to
afbd07a
Compare
chenyukang
force-pushed
the
yukang-fix-151985-unused-parens-method-receiver
branch
from
March 26, 2026 14:13
afbd07a to
d9ef5b9
Compare
Contributor
|
☔ The latest upstream changes (presumably #155567) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the
unused_parenslint to detect unnecessary parentheses around method receivers like(x).method().Fixes #151985